-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bin: Fix exit code propagation #50
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for finding and fixing this! It's a pretty serious defect so I guess we should make a release right after it's merged.
Now that we're loading entrypoints as modules, exit codes no longer propagate in the same way. Therefore, we must do that explicitly through the system exit function. Without this the exit code is always ZERO and in practical terms all CI pipelines depending on this are always passing even when the tests are actually failing. See 7825a0c.
@ptomato I addressed your comments, plus removed some unnecessary function wrapping... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Now that we're loading entrypoints as modules, exit codes no longer propagate in the same way. Therefore, we must do that explicitly through the system exit function.
Without this the exit code is always ZERO and in practical terms all CI pipelines depending on this are always passing even when the tests are actually failing.
See 7825a0c.
To reproduce:
Build latest jasmine-gjs from master (c6aa28b).
Use the following sample test.
With out this PR the exit code is always ZERO.